search

Techtonica / keyboard-shortcuts-practice

https://techtonica.github.io/keyboard-shortcuts-practice/
26 stars 56 forks source link

Bug: npm start cannot work on Windows #100

Closed vegetabill closed 3 years ago

vegetabill commented 3 years ago

Currently npm start runs NODE_ENV=development nodemon but that only works on unix/mac.

Please look into a cross-platform way to specify env variables, if one exists or a way to vary the script based on platform.

vegetabill commented 3 years ago

I have seen this used before but there might be other ways too: https://github.com/kentcdodds/cross-env

vegetabill commented 3 years ago

For a workaround on windows, you can just remove the NODE_ENV=production in package json command:

https://github.com/Techtonica/keyboard-shortcuts-practice/blob/12b8ae0acd99ae57ec81dba48cf89ddd77d04b06/package.json#L9

Please don't commit this if possible.

paulrrdiaz commented 3 years ago

Hey @vegetabill could I work on this?

paulrrdiaz commented 3 years ago

@alodahl done