Techtonica / keyboard-shortcuts-practice

https://techtonica.github.io/keyboard-shortcuts-practice/
27 stars 56 forks source link

added shortcut type tag to JSON object and main screen #103

Closed bellbytes closed 4 years ago

bellbytes commented 4 years ago

Changes

Screen Shot 2020-10-01 at 2 20 58 PM

Related Issue

fixes #47

vegetabill commented 4 years ago

@belebull thanks for submitting this! We'll be reviewing it shorly.

GitHub tip: if you edit your description to use one of the special keywords, it will automatically link the issue and make it easier for you to get credit for the PR.

By prefacing your commits with “Fixes”, “Fixed”, “Fix”, “Closes”, “Closed”, or “Close” when the commit is merged into main, it will also automatically close the issue.

bellbytes commented 4 years ago

@belebull thanks for submitting this! We'll be reviewing it shorly.

GitHub tip: if you edit your description to use one of the special keywords, it will automatically link the issue and make it easier for you to get credit for the PR.

By prefacing your commits with “Fixes”, “Fixed”, “Fix”, “Closes”, “Closed”, or “Close” when the commit is merged into main, it will also automatically close the issue.

Thanks for letting me know!

bellbytes commented 4 years ago

The tag works, but are some of these shell shortcuts? Like control+q, control+l, control+u, control+w?

Great catch - I was looking at the cheat sheet and didn't see some of the shell commands there. I'll make an update!

bellbytes commented 4 years ago

Would you mind making the shell v mac tags different colors? I was focused on seeing it change and I almost didnt notice.

Let me know if this color change works!

Screen Shot 2020-10-01 at 5 26 44 PM
alodahl commented 4 years ago

I don't know what I'm doing wrong, but I'm no longer seeing any tags at all.

bellbytes commented 4 years ago

That's odd - I'm looking at my dev now and it looks fine even after reloading the page and restarting npm. Any suggestions on how to fix this?

alodahl commented 4 years ago

You can pick up something else while we're waiting =)

alodahl commented 4 years ago

Whoa, great idea @tilaprimera , maybe we can make that into a new issue.