search

Techtonica / keyboard-shortcuts-practice

https://techtonica.github.io/keyboard-shortcuts-practice/
27 stars 56 forks source link

Fixes #89 - Add prettier support #105

Closed swarna-gopalan closed 4 years ago

swarna-gopalan commented 4 years ago

fixes #89 Add prettier support and enforce with commit hook

vegetabill commented 4 years ago

Thanks for submitting. If you prefix the issue number with Fixes it will automatically link the issue.

alodahl commented 4 years ago

hi @swarna-gopalan , are you still out there? Will you be able to make changes today?

swarna-gopalan commented 4 years ago

Hi Alina,

I'll give it a try or I can still work on this tomorrow if that's ok?

Thanks!

On Thu, Oct 1, 2020 at 7:12 PM Alina L. notifications@github.com wrote:

hi @swarna-gopalan https://github.com/swarna-gopalan , are you still out there? Will you be able to make changes today?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Techtonica/keyboard-shortcuts-practice/pull/105#issuecomment-702460302, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHUP326BGR6RO5YFXAA67TSIULGRANCNFSM4SA3W5TQ .

-- Swarna

vegetabill commented 4 years ago

As a simplification, we can drop all the linting aspects and just setup prettier config and commit hook. That would mostly cover what is important. @alodahl what do you think?

In retrospect, I probably picked an overly complicated blog 😕

alodahl commented 4 years ago

@vegetabill i guess, but what would that be eliminating? Maybe a different tutorial is necessary; I didn’t think it would be very complex, just the right configurations.

vegetabill commented 4 years ago

@alodahl it would just be adding a set prettier config so that anyone using something like vscode's formatting would all be using the same rules. Since the code is quite non-standard, eslint might be a tough transition at this point.

Either way, since this was mainly to make OSD easier (oops), I'd say let's just close this PR unmerged and just throw the issue back into the to-do list for someone who knows of a better setup. Sorry!