search

Techtonica / keyboard-shortcuts-practice

https://techtonica.github.io/keyboard-shortcuts-practice/
27 stars 56 forks source link

Replace use of jQuery add/remove class #111

Closed vegetabill closed 4 years ago

vegetabill commented 4 years ago

We are using jQuery DOM selectors to toggle classes and visibility in main.js but now all of those functionalities are part of the browser built-in functions.

For all usages of CSS class add and remove functions, e.g.

https://github.com/Techtonica/keyboard-shortcuts-practice/blob/27c54db1ce3187f2f40434fdabe677976d53cedc/public/scripts/main.js#L116

or

https://github.com/Techtonica/keyboard-shortcuts-practice/blob/27c54db1ce3187f2f40434fdabe677976d53cedc/public/scripts/main.js#L131

Replace with the equivalent using the standard document.querySelector and Element.classList

i-aryan commented 4 years ago

Hey. I can get it done! Assign, please @vegetabill

Shraddha2104 commented 4 years ago

Assigned!