search

Techtonica / keyboard-shortcuts-practice

https://techtonica.github.io/keyboard-shortcuts-practice/
27 stars 56 forks source link

Replacing Jquery with Fetch #114

Closed aucodes closed 4 years ago

vegetabill commented 4 years ago

Sorry @astha01 someone didn't follow the process and already merged a different change that was the same. I'm going to have to close this PR.

alodahl commented 4 years ago

@vegetabill which change was merged in?

apoorva-mk commented 4 years ago

@alodahl another PR which didn't reference the issue has already been merged. Which is also why there were conflicts.

alodahl commented 4 years ago

Oh, I see. https://github.com/Techtonica/keyboard-shortcuts-practice/pull/109/files

Sorry @astha01, here are some open issues: https://github.com/Techtonica/keyboard-shortcuts-practice/projects/4#column-4132662

vegetabill commented 4 years ago

@astha01 just letting you know we ended up merging this PR. Sorry for the confusion/miscommunication! Thanks for contributing.