Closed alodahl closed 4 years ago
I'm interested in working on this.
I am interested in working on this.
@rpytan I've assigned you but feel free free to pair with @MariaKhantech if you'd like!
Hi @rpytan not sure how much progress you made on OSD or if you anticipate having time to finish it. If not, perhaps @MariaKhantech might be interested in working on it or we can also just unassign it for someone else to pick up. Either way is fine. Just let us know. Thanks!
Hi! @vegetabill I would like to work on this issue if the PR has not yet been created, I can still wait for the response from the people who are assigned to it.
Ohh I had not seen that you solved it
Hi Bill, Sorry for the late reply. Unfortunately, I was not able to make much progress during OSD and I don't think I will have time to continue with it.
On Mon, Oct 5, 2020 at 6:07 PM Bill DePhillips notifications@github.com wrote:
Hi @rpytan https://github.com/rpytan not sure how much progress you made on OSD or if you anticipate having time to finish it. If not, perhaps @MariaKhantech https://github.com/MariaKhantech might be interested in working on it or we can also just unassign it for someone else to pick up. Either way is fine. Just let us know. Thanks!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Techtonica/keyboard-shortcuts-practice/issues/74#issuecomment-703935791, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJOYQVH6C4E7HDH7LO32E3SJJGSJANCNFSM4RKIAPWA .
Thanks for the offer, @y-martinez. Hopefully you see another issue that interests you. We have a bunch. If you need help finding one, please let me know.
Since I worked on a spike of Auth0/dev auth while we were creating the issues, I am adapting that spike code for a PR that will be ready soon. Assigning to me in the meantime.
Auth0 is being integrated as part of #73 but we don't want to force all contributors to configure Auth0 just to work on the app so we'll have a simple auth setup for local development.
Feel free to suggest a better way to do this. This just one possible way among many.
GET /login
endpointuserId
which will just be the environment variableUSER
(your OS username) which has a lifetime of 1 hourfindOrCreate
helper that makes this easy/
GET /logout
endpoint/
/user/progress
endpoint added in #66 so that the userId will be the logged-in user id if the cookie has the value setIf you have any question about cookies, Express, ping Bill D in Slack.