TechzoneMC / CombatTagLegacy

UNSUPPORTED - Please switch to CombatTagPlus https://www.spigotmc.org/threads/combattagplus.54409/
7 stars 3 forks source link

Broken PlayerQuitEvent, plugin totally broken #20

Open vemacs opened 9 years ago

vemacs commented 9 years ago
[03:40:03] [Server thread/ERROR]: Could not pass event PlayerQuitEvent to CombatTag v6.4.1-SNAPSHOT
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:305) ~[paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.PlayerList.disconnect(PlayerList.java:372) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.PlayerConnection.a(PlayerConnection.java:849) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.NetworkManager.l(NetworkManager.java:315) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.ServerConnection.c(ServerConnection.java:145) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.MinecraftServer.A(MinecraftServer.java:863) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.DedicatedServer.A(DedicatedServer.java:372) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.MinecraftServer.z(MinecraftServer.java:703) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.MinecraftServer.run(MinecraftServer.java:606) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45]
Caused by: java.lang.NullPointerException
        at com.trc202.CombatTag.libs.npclib.nms.versions.v1_8_R2.NMS.makeProfile(NMS.java:111) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.versions.v1_8_R2.NMS.setSkin(NMS.java:91) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.NMSNPC.trySetSkin(NMSNPC.java:146) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.NMSNPC.spawn(NMSNPC.java:112) ~[?:?]
        at com.trc202.CombatTag.NPCManager.spawnHumanNPC(NPCManager.java:41) ~[?:?]
        at com.trc202.CombatTag.CombatTag.spawnNpc(CombatTag.java:175) ~[?:?]
        at com.trc202.CombatTagListeners.NoPvpPlayerListener.onPlayerQuit(NoPvpPlayerListener.java:81) ~[?:?]
        at sun.reflect.GeneratedMethodAccessor445.invoke(Unknown Source) ~[?:?]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45]
        at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:301) ~[paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        ... 12 more
ams2990 commented 9 years ago

The same error with 1.8.6 and c07dc3ef8df7e0313d6d7ae33a18a7ad7f270d7f:

[ERROR] Could not pass event PlayerQuitEvent to CombatTag v6.4.1-SNAPSHOT
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot.jar:git-Spigot-c5146ba-c637b93]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-c5146ba-c637b93]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.PlayerList.disconnect(PlayerList.java:346) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:844) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.NetworkManager.l(NetworkManager.java:314) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.ServerConnection.c(ServerConnection.java:145) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:817) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:367) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:657) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:560) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45]
Caused by: java.lang.NullPointerException
        at com.trc202.CombatTag.libs.npclib.nms.versions.v1_8_R3.NMS.makeProfile(NMS.java:111) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.versions.v1_8_R3.NMS.setSkin(NMS.java:91) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.NMSNPC.trySetSkin(NMSNPC.java:146) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.NMSNPC.spawn(NMSNPC.java:112) ~[?:?]
        at com.trc202.CombatTag.NPCManager.spawnHumanNPC(NPCManager.java:41) ~[?:?]
        at com.trc202.CombatTag.CombatTag.spawnNpc(CombatTag.java:175) ~[?:?]
        at com.trc202.CombatTagListeners.NoPvpPlayerListener.onPlayerQuit(NoPvpPlayerListener.java:81) ~[?:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_45]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_45]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45]
        at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot.jar:git-Spigot-c5146ba-c637b93]
        ... 12 more
Agazed commented 9 years ago

I confirm

Agazed commented 9 years ago

Is this going to be fixed? Plugin is completely broken.

Techcable commented 9 years ago

It will be fixed, i'll just have to revert one commit :smile:

Agazed commented 9 years ago

Well, which commit is it? Can you not just do it? I rely on your plugin for my large community and I really need a working version so people stop combat logging.

Techcable commented 9 years ago

NPCLib@1cddc524ae Reverting it causes compile errors i have to fix.

rourke750 commented 9 years ago

Any news on this?

Agazed commented 9 years ago

It's been almost a month this plugin is completely broken. Pretty sure this project is abandoned.... :(

Techcable commented 9 years ago

Try build #15

rourke750 commented 9 years ago

There is no 15

rourke750 commented 9 years ago

Nvm there is now

Techcable commented 9 years ago

@rourke750 It was building :wink:

Agazed commented 9 years ago

Build 15 still doesnt work. When a player logs out, no entity is produced an there is no error in the console. But it still says to the Admins that a player combat logged.

Agazed commented 9 years ago

???????????

Techcable commented 9 years ago

Try build 18 (latest is better) of Combat Tag 7.0.0 beta

dwaynehulsman commented 9 years ago

Link is dead, new one please?

Techcable commented 9 years ago

@xxroltsxx Fixed.

dwaynehulsman commented 9 years ago

I'm getting this when a player leaves while tagged: http://pastebin.com/pvYJsJnt

Techcable commented 9 years ago

@xxroltsxx Are you sure you are on build 21?

dwaynehulsman commented 9 years ago

Yes

Techcable commented 9 years ago

Fixed By NPCLib@79129e903edf8 (build 22) Since the original issue is fixed, i'm closing this. And please open a new issue for a new problem @xxroltsxx .