search

Tecnativa / docker-whitelist

A socat service to whitelist network connections
Apache License 2.0
8 stars 8 forks source link

Add linux/arm64 platform to Docker build #17

Closed PCatinean closed 10 months ago

PCatinean commented 10 months ago

Rebased on https://github.com/Tecnativa/docker-whitelist/pull/14 so pre-commit passes

pedrobaeza commented 10 months ago

Please do a rebase over main branch for leaving only 1 commit.

PCatinean commented 10 months ago

@pedrobaeza done

PCatinean commented 10 months ago

@pedrobaeza it seems the pipeline has failed with "Error: Error response from daemon: login attempt to https://registry-1.docker.io/v2/ failed with status: 503 Service Unavailable". Not sure if it's just a glitch which works on retry of the pipeline or maybe an update on the github actions is needed

PCatinean commented 10 months ago

@pedrobaeza thanks for the merge and pipeline re-run, seems it worked and pushed but it tagged it with :edge https://github.com/tecnativa/docker-whitelist/pkgs/container/docker-whitelist. This means arm users would need to use a different tag for the odoo_proxy service and the one from copier will not work out of the box. Not sure if you need to manually set the tag to latest or if this should be included in the CI/CD pipeline :man_shrugging:

pedrobaeza commented 10 months ago

Learnt on the fly how this goes (doing a tag on the repository itself). There's a weird unknown/unknown architecture now, but I think it's not a big deal.

PCatinean commented 10 months ago

Yes I saw that too and also thought it was strange. In any case it seems to work well now with the latest tag, thanks!