search

Tecnativa / doodba-scaffolding

Officially supported scaffolding template for your Doodba projects
Other
11 stars 38 forks source link

Inverseproxy #59

Closed yelizariev closed 4 years ago

yelizariev commented 4 years ago

Is there special reason, why inverproxy.yaml file is not in scaffolding? If this will be merged, I'd make corresponding updates in doodba's README

yajo commented 4 years ago

Yes, it's because in a single server there might be several odoo instances, but just one inverseproxy. Also it is only useful for test/prod environments. Also some people would still prefer nginx/apache/etc.

So it's not included on purpose.

yelizariev commented 4 years ago

My concern is mostly about the fact, that the file content has to be copy-pasted from the documentation.

Doodba-scaffolding already has traefik configuration related to the inverseproxy file

https://github.com/Tecnativa/doodba-scaffolding/blob/4f8b1dc425a028237697a602cd0d09f3379ea6b7/prod.yaml#L22-L29

so, it should be a good place for the file. Though, I understand the idea to keep here files for a single project only (while inverseproxy could be used on top of multiple projects)

yajo commented 4 years ago

It would be more useful to have another project about handling the inverse proxy thing. But that would fit better an ansible role or something like that.

The labels you point are there to make the scaffolding compatible out of the box with the provided traefik settings, but still these are separate pieces of the puzzle.

Thanks for your understanding.