Tecsisa / constructr-consul

This library enables to use Consul as cluster coordinator in a ConstructR based node
Apache License 2.0
32 stars 15 forks source link

Log communication with consul (closes #9) #10

Closed raboof closed 8 years ago

raboof commented 8 years ago

Logs errors on ERROR, requests, responses and completions on DEBUG. This logs to the `com.tecsisa.constructr.coordination.consul.ConsulCoordination" logger with a prefix to distinguish request and response.

gerson24 commented 8 years ago

hi @raboof, thanks for the contribution.

Please, if you don't mind pull the new commits from master and update the PR. There's fresh work regarding DNS resolution (see https://github.com/hseeberger/constructr/issues/93) that cannot be lost. Thanks!

raboof commented 8 years ago

@gerson24 protected against this by (as suggested in that issue) creating a new connection for each request.

Would be nice to add a test for this, but I don't quite see an elegant way to achieve that.