Closed Tectu closed 3 years ago
Personally I don't like to see code like this in an application / outside of a library:
class my_app { private: malloy::websocket::connection<false> m_ws; };
It is not immediately clear what this boolean template parameter does without further investigation (or simply knowing it).
I would vote for adding type aliases for client & server connections which are defined as connection<true> and connection<false> respectively.
connection<true>
connection<false>
@0x00002a any thoughts?
@Tectu https://github.com/Tectu/malloy/blob/9eecc9cc9da9ca22d28323fcaec832df9a974ac0/lib/malloy/server/websocket/connection/connection.hpp#L19?
🤦 Don't hate me 😋
Personally I don't like to see code like this in an application / outside of a library:
It is not immediately clear what this boolean template parameter does without further investigation (or simply knowing it).
I would vote for adding type aliases for client & server connections which are defined as
connection<true>
andconnection<false>
respectively.@0x00002a any thoughts?