search

Tectu / malloy

A cross-platform C++20 library providing embeddable server & client components for HTTP and WebSocket.
BSD 3-Clause "New" or "Revised" License
66 stars 8 forks source link

Set agent strings properly #37

Closed Tectu closed 3 years ago

Tectu commented 3 years ago

Currently, agent strings are all over the place. This needs some cleaning up / more consistency.

We want to have something like malloy-client <version> and malloy-server <version>.

0x00002a commented 3 years ago

Could add it to the config along with #35, have a default and then let the user customise it if they really want

Tectu commented 3 years ago

I've been wondering whether there is a scenario where a user might want to have different agent strings for different connections of the same type. For example, given an HTTP server, would a connection ever need to have a different agent string than other HTTP connections served by the same server?

I couldn't think of any such case.

Tectu commented 3 years ago

@0x00002a how busy are you currently? I'd really like to move to the first release ASAP to make maintaining applications consuming this library easier and hopefully also attracting more users & contributors.

Do you feel like giving this a go?

0x00002a commented 3 years ago

Sure, I'll have a crack at it along with #35 tomorrow