search

Tectu / malloy

A cross-platform C++20 library providing embeddable server & client components for HTTP and WebSocket.
BSD 3-Clause "New" or "Revised" License
66 stars 8 forks source link

fix: subrouter endpoint_http_regex not matching #57

Closed 0x00002a closed 3 years ago

0x00002a commented 3 years ago

Fixes: #56

This ones on me. I remember doing some testing here but I think that must've only been with the file and websocket endpoints. I don't really use subrouters currently so I didn't catch it, sorry :p.

0x00002a commented 3 years ago

Well MSVC + TLS boost v1.75.0 ran out of RAM... what

0x00002a commented 3 years ago

..\test\test_suites\components\websockets.cpp(177): fatal error C1060: compiler is out of heap space

From: https://github.com/Tectu/malloy/pull/57/checks?check_run_id=3033032178, it seems the runner does not have enough ram... but only with msvc + tls + boost 1.75.0 and due to a single line of code being added. The specs say they should have 7GB (docs)

Tectu commented 3 years ago

..\test\test_suites\components\websockets.cpp(177): fatal error C1060: compiler is out of heap space

From: https://github.com/Tectu/malloy/pull/57/checks?check_run_id=3033032178, it seems the runner does not have enough ram... but only with msvc + tls + boost 1.75.0 and due to a single line of code being added. The specs say they should have 7GB (docs)

lol ^^ Should we disable that specific build config or...? I mean, there's not much we can do about it.