Tectu / malloy

A cross-platform C++20 library providing embeddable server & client components for HTTP and WebSocket.
BSD 3-Clause "New" or "Revised" License
68 stars 8 forks source link

Build with werror #66

Closed 0x00002a closed 3 years ago

0x00002a commented 3 years ago

This adds the following flags:

gcc/clang

msvc

The code has been changed to allow the codebase to actually compile with warnings as errors. Some potentially nasty bugs were caught, including the fact that connection::handler had a non-virtual dtor.

Note: On mingw Werror is disabled, because the 3rdparty headers emit warnings

Closes: #62

Tectu commented 3 years ago

Pretty solid PR - Thanks a lot!