This fixes the shared library + downloaded spdlog configuration (which runs into link errors otherwise). The problem was that MALLOY_BUILD_SHARED was not propagated to spdlog. Unfortunately I didn't catch this because I use external spdlog + conan for my local linux environment and didn't add the shared config to the CI.
This patch also adds the shared config to the CI, however it is disabled until #55 is resolved (since it won't build on msvc until then)
Tectu
commented
3 years ago
This fixes the shared library + downloaded spdlog configuration (which runs into link errors otherwise). The problem was that
MALLOY_BUILD_SHAREDwas not propagated tospdlog. Unfortunately I didn't catch this because I use external spdlog + conan for my local linux environment and didn't add the shared config to the CI.This patch also adds the shared config to the CI, however it is disabled until #55 is resolved (since it won't build on msvc until then)