search

Tectu / malloy

A cross-platform C++20 library providing embeddable server & client components for HTTP and WebSocket.
BSD 3-Clause "New" or "Revised" License
68 stars 8 forks source link

Add windows dll exports #81

Closed 0x00002a closed 3 years ago

0x00002a commented 3 years ago

This adds windows symbol exports, via the cmake option WINDOWS_EXPORT_ALL_SYMBOLS. This should catch everything, and the tests run, but there may be some static data members I've overlooked (I'm not sure if constexpr static counts).

Resolves: #55

0x00002a commented 3 years ago

@Tectu I am concerned that the shared msys build seems to be spinning forever on the tests

Tectu commented 3 years ago

@0x00002a yep, seems that way. It seems to be the case only with shared: ON. It also seems like the build passes, the tests just don't run to completion.

Might this be related to the spdlog shared binary being "unavailable"? I do think that then it would just crash immediately.

0x00002a commented 3 years ago

Might this be related to the spdlog shared binary being "unavailable"? I do think that then it would just crash immediately.

I can't see the logs in the CI, can you repro it? The spdlog binary should be copied into the right dir since I had to do it for msvc to work