Currently there is a find_package call for boost but its never used. This is fine in the case where boost has been installed to the system or similar, but it doesn't work for builds that rely on the boost package files adding the include paths (e.g. conan). Adding boost::headers (or boost::boost) to the public linked libraries of malloy-objs fixes this but requires BOOST_DATE_TIME_NO_LIB to be added to the compile definitions on windows (otherwise you get a link error).
This is the last of the modifications I made to get this library to build with conan + MSVC. I tested the build with fedora + system boost install so I don't think it breaks existing setups.
Tectu
commented
3 years ago
Currently there is a
find_packagecall for boost but its never used. This is fine in the case where boost has been installed to the system or similar, but it doesn't work for builds that rely on the boost package files adding the include paths (e.g. conan). Addingboost::headers(orboost::boost) to the public linked libraries of malloy-objs fixes this but requiresBOOST_DATE_TIME_NO_LIBto be added to the compile definitions on windows (otherwise you get a link error).This is the last of the modifications I made to get this library to build with conan + MSVC. I tested the build with fedora + system boost install so I don't think it breaks existing setups.