Tectu / malloy

A cross-platform C++20 library providing embeddable server & client components for HTTP and WebSocket.
BSD 3-Clause "New" or "Revised" License
66 stars 8 forks source link

Endpoint test suite fails to build #93

Closed Tectu closed 2 years ago

Tectu commented 2 years ago

Since commit 9bf5a3ce9ea9ebfc5d082086664bf874c50a148c the endpoints.cpp test suite fails to build.

Temporarily disabled in commit 5298388db27b1b42d70fbf7400d3f5d89de57333.

Tectu commented 2 years ago

@0x00002a feel free to join back in if you have time & motivation during the holidays :p

Tectu commented 2 years ago

The problem boils down to malloy::http::request not providing a constructor accepting an HTTP header.

0x00002a commented 2 years ago

Thats... weird. Why didn't it fail to build before is whats confusing me. As far as I can tell from the history, that code should never have compiled in the first place. I'm guessing theres some template that wasn't instantated but again I can't see anything that would cause that in 9bf5a3ce9ea9ebfc5d082086664bf874c50a148c.

Tectu commented 2 years ago

Thats... weird. Why didn't it fail to build before is whats confusing me.

You and me both... :D I'm truly perplexed by this one.