search

Tedster59 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion
8 stars 1 forks source link

Consider removing LW2 attempt to fix corpses dropped by MC-ed enemies #29

Open GafrieGithub opened 1 year ago

GafrieGithub commented 1 year ago

Here is the LW2 code which make enemies who are mind controlled at the end of full salvage missions to drop their corpses: https://github.com/Tedster59/lwotc/blob/4957602884a8afabfa522ccc8cb8e40a8365d3f4/LongWarOfTheChosen/Src/LW_Overhaul/Classes/X2EventListener_Tactical.uc#L687 However, it works poorly with mods like "[WOTC] Dude, Where's My Loot?" or formerly "[WOTC] Loot Mind Control]" in that LW2 fixes only the corpses. If you are not using other mod, then you are missing on certain loot, and if you are using other mod then you get your loot, but also double the amount of corpses. So no matter what you do currently the overall amount of stuff you get is incorrect. The easiest solution would be just to comment this section out and to warn players to just use a mod specifically focused on solving this issue.

copyrite commented 11 months ago

This would now make more sense on the main repo, https://github.com/long-war-2/lwotc/issues. Would you like to recreate it there, or shall I?

copyrite commented 10 months ago

Actually, nevermind. One can transfer GH issues between forks. @Tedster59, since you have the rights to both, could you do it? Should be a "-> Transfer issue" in the bottom right.

copyrite commented 10 months ago

Copied to long-war-2, can be closed.