TeemuKoivisto / prosemirror-dev-toolkit

Injectable developer tools for ProseMirror rich-text editors implemented in Svelte and TypeScript.
https://teemukoivisto.github.io/prosemirror-dev-toolkit/
MIT License
117 stars 6 forks source link

Devtools yield "URI Malformed" error when unicode emoji present #11

Open percy507 opened 2 years ago

percy507 commented 2 years ago

Hi @TeemuKoivisto ,

Thanks for your work. 👏

I find a bug just now. After some research, it seems this is an old bug which exist in prosemirror-dev-tools. And it is also exist in this package. It is greatful if you can take a look at it.

TeemuKoivisto commented 2 years ago

Hey @percy507 !

Thanks, never actually have noticed that one. But ugh, seems like the problem lies in jsondiffpatch library (surprise surprise). Well, there are basically two options here: try to get the fix merged to the original package which has been unmaintained for some time. Or two, and which I really would not want to do, fork the lib and fix that bug by myself (as well as update its dependencies).

But I really wouldn't want to have to maintain/fix yet another package. Especially one with legacy code I don't know anything about. I'll see what I can do.