Teester / Whats-Nearby

Android App for collecting information about POIs for OpenStreetMap
GNU General Public License v3.0
13 stars 2 forks source link

F-Droid #39

Open rugk opened 6 years ago

rugk commented 6 years ago

Could you release it on F-Droid?

IzzySoft commented 5 years ago

If you confirm, I gladly help you along. Until the process is through: could you at least add an .apk to the releases/? That would enable me provind the app via my repo, at least until it's published at F-Droid.

IzzySoft commented 5 years ago

Just wondering: Did you miss it, or aren't you interested?

Teester commented 5 years ago

Apologies. I forgot about this issue. Ive added the release apks from 0.11 to 0.20 to the app/releases directory of the repo.

I intend to publish on FDroid, but only once the app is no longer in beta. We're pretty much there. As long as 0.20 doesn't show up any significant issues, I'll release to production on Google Play and publish on FDroid around the same time.

I'll keep this issue open until the app is published on FDroid.

IzzySoft commented 5 years ago

Apologies. I forgot about this issue.

Happens – hence the friendly reminders :wink:

Ive added the release apks from 0.11 to 0.20 to the app/releases directory of the repo.

Thanks a lot, will go after them now. Though they'd better be added to the corresponding releases/, to not bloat the repo itself (remember all stuff in the repo comes along when forking/cloning). If you've moved them over, just let me know, please.

I intend to publish on FDroid, but only once the app is no longer in beta.

Sounds absolutely reasonable. There are several apps where the stable version is in the official repo, while a beta/testing/nightly-build/weekly-build is in my repo, usually going by a different package name.

You might also consider putting the screenshots into a Fastlane structure (see here for details). That can be used with F-Droid as well as with Playstore to automatically get them included. Further, you probably need to remove Parse.com then (e.g. using a separate flavor for F-Droid if you want to keep it in the Playstore version).

I'll keep this issue open until the app is published on FDroid.

Good idea, thanks!

PS: Your app should go live in my repo tonight. Could be useful for your testers to get automatic updates.

Teester commented 5 years ago

@IzzySoft: regarding your comment about Parse.com, there is no analytics suite used in the app (that I'm aware of). I suppose it's possible that one of the dependencies use it, but I can't find any reference in any of their docs.

Do you tools have more information about why they think the app uses parse.com, or is it possible that it's a false positive?

IzzySoft commented 5 years ago

@Teester I have no idea. Maybe ask over there, so a dev can take a look?

IzzySoft commented 5 years ago

I've just digged a little (unsuccessfully), thinking one of the libraries might bring in along. Maybe parse.com is "wrongly detected" by something using it as prefix (com.parse.*) – I've often seen that with e.g. com.facebook.* (e.g. Stetho), com.google.android.* (e.g. Muzei), and others. If you find out what is creating that path, please let me know so I can fix my detection patterns.

IzzySoft commented 5 years ago

Back home, I've found the culprit. I've analyzed the smali manually and indeed found no hint on parse.com – but LibRadar was sure it had identified Parse in an obfuscated path ("com/a/a/"). Luckily LibRadar is open source – so trusting you more than that rule (which might be simply no longer correct, or must at least have been triggered falsely – and apart from that, I found no hint on Parse.com in your gradle either), I've disabled that rule.

So apologies for the false accusations – but that indeed was the first false positive since I started using that library some years ago.

All should be fine now – so just ping me when you're ready for the official repo!

IzzySoft commented 4 years ago

@Teester just wondering: are you still maintaining this app? No (visible) activity for a year now.

rugk commented 4 years ago

Opened https://github.com/Teester/Whats-Nearby/issues/53 for this.