Teester / entityshape

An api to compare a wikidata item with an entityschema
GNU General Public License v3.0
5 stars 3 forks source link

Look at qualifiers when deciding to check schema #46

Closed Teester closed 4 months ago

Teester commented 4 months ago

Resolves #45

Looks at the qualifiers of properties in P12861 to determine whether to add them to the schema list or not

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.17%. Comparing base (9a8fd88) to head (c80404a).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Teester/entityshape/pull/46/graphs/tree.svg?width=650&height=150&src=pr&token=hYiDYYS8VA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mark+Tully)](https://app.codecov.io/gh/Teester/entityshape/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mark+Tully) ```diff @@ Coverage Diff @@ ## master #46 +/- ## ======================================= Coverage 90.17% 90.17% ======================================= Files 6 6 Lines 967 967 ======================================= Hits 872 872 Misses 95 95 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/Teester/entityshape/pull/46?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mark+Tully). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mark+Tully) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/Teester/entityshape/pull/46?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mark+Tully). Last update [9a8fd88...c80404a](https://app.codecov.io/gh/Teester/entityshape/pull/46?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mark+Tully). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mark+Tully).
sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud