TehCheat / PoEHUD

174 stars 121 forks source link

Fixing preloads, setting debug configuration to be not optimized, fix… #370

Closed Macaddict42 closed 5 years ago

Macaddict42 commented 5 years ago
  1. Removed Syndicate Interception preload because the asset is always being loaded no matter what zone you're in.
  2. Fixed Syndicate Research preload
  3. Uncommented Task.Run around new PluginExtensionPlugin. Stridemann commented this out because he said it was giving him issues but I've been using it for over a year without issue. This class definitely hangs for a second or two when being created, so it's good to run it on a separate thread.
  4. The Assembly.Load being used for plugins wasn't inside the try/catch so it could crash PoEHud instead off handling the exception. Generally, Assembly.LoadFrom is more robus than Assembly.Load anyways. I also added the catch for BadImageFormatException in the case that PoEHud attempts to load a 32bit plugin or non-C# dll.
  5. Changed the debug configuration to not be optimized, this is necessary to hit any breakpoint while debugging. Not sure why it's set to true anyways. If you want to optimize, that's what the Release configuration is for.