search

TehFishey / stellaris-crisis-managers

A set of mods for the video game Stellaris, which allow in-game configuration of various midgame and lategame crises and events.
MIT License
6 stars 1 forks source link

Missing Variables, Constants, and Flags #3

Open TehFishey opened 4 years ago

TehFishey commented 4 years ago

A few scripted variables, constants, and flags appear to be missing from the crisis manager files:

Variables: CmtVarLgateCycleStandard CmtVarLgateCycleStandard

Constants: @CmtT101_ConstLgateClusterType @CmtT101_ConstCrisisPower_Endgame

Flags: CmtFlagUprisingEdition CmtFlagFeeCompatPatch CmtFlagConfigViewerShowing1025

Determine the intended purposes of these objects; add them with proper values if they are necessary, or remove them if not.

TehFishey commented 4 years ago

CmtVarLgateCycleStandard is deprecated since FirePrince's changes; replace with CmtVarLgateCycleCommon.

@CmtT101_ConstLgateClusterType appears to be depreciated constants which are included for backwards compatability purposes. It can probably be safely removed (along with other backwards compat stuff), considering that the mod is now for a new version of the game (savegame compat with previous editions is impossible)

@CmtT000_ConstCrisisPower_Endgame seems to be an obsolete constant; the same template variable is properly set using @CmtT000_ConstCrisisStrengthEnd at other points in the script. Consider removing.

The first two flags are to recognize other editions of the game which no longer exist in this version. Leaving them as they are shouldn't hurt until we can properly implement the features from those mods (and decide for 100% that we won't just update them).

CmtFlagConfigViewerShowing1025 is a display flag for a config viewer that no longer exists. It's probably fine to leave in right now.

F1r3Pr1nc3 commented 4 years ago

Yes, it should all be easy doable. I made a beginning (Constants done)