KMP Breaks Kethane-Mod

[Aringarosa]

The Build: e935cee4cac05f91e590d664689485566aa4d89f

Output.log http://pastebin.com/Gs5jXFKM

KSP.log http://pastebin.com/GvQSLpL4

leads to the Kethane mod in version 0.8.4 no longer works properly. It is a strange error that has to do with the Kethane / settings.cfg. , As follows:

1) If you delete the settings.cfg and KSP launches loads of normal functional with Kethane.

2) Benedet you then KSP and restarts remains the loading screen at the beginning gelich stand for about 5-10sec and then loads further. Once in the main menu one can see the Kethane is not loaded properly because the Kerbin has no grid. In KSP log is the following:

[LOG 10:16:21.815] AssemblyLoader: Loading assembly at E:\Steam\steamapps\common\Kerbal Space Program\GameData\VOID\Plugins\VOID.dll [LOG 10:16:21.854] AssemblyLoader: Loading assemblies [LOG 10:16:21.885] TestManager: Adding unit test: KMP.Bootstrap [LOG 10:16:21.889] [Info] : *\ KMP version 0.1.5.1 started [LOG 10:16:22.269] [Info] : KMP started in LogLevel Info [LOG 10:16:44.316] KMP loaded [LOG 10:16:44.316] TestManager: Adding unit test: KMP.Bootstrap [LOG 10:16:44.317] TestManager: Adding unit test: KMP.Bootstrap [LOG 10:16:44.318] TestManager: Adding unit test: KMP.Bootstrap [LOG 10:16:44.340] AddonLoader: Instantiating addon 'ConfigManager' from assembly 'ModuleManager_1_5_6' [LOG 10:16:44.342] AddonLoader: Instantiating addon 'ToolbarManager' from assembly 'Toolbar' [LOG 10:16:44.348] AddonLoader: Instantiating addon 'SettingsManager' from assembly 'Kethane' [LOG 10:16:44.350] AddonLoader: Instantiating addon 'ScaledSpaceFix' from assembly 'Kethane' [LOG 10:16:44.351] AddonLoader: Instantiating addon 'MapOverlay' from assembly 'Kethane' [WRN 10:16:44.361] [Kethane] Loading settings [EXC 10:16:44.367] IOException: Sharing violation on path E:\Steam\steamapps\common\Kerbal Space Program\GameData\Kethane\settings.cfg [EXC 10:16:44.375] IOException: Sharing violation on path E:\Steam\steamapps\common\Kerbal Space Program\GameData\Kethane\settings.cfg [LOG 10:16:44.382] AddonLoader: Instantiating addon 'TutorialInstaller' from assembly 'Kethane' [LOG 10:16:44.383] AddonLoader: Instantiating addon 'RTDebugUnit' from assembly 'RemoteTech2'

In 10:16:22.269 he hangs up and continues with 10:16:44.316. In 44:367 then the damage is the settings.cfg on what brought me in the first place the idea to remove them.

3) If you delete now the settings.cfg again you can normally start without errors and play. And so again and again. With the build of 14.1. there was not yet the error.

[godarklight]

https://github.com/hashashin/KerbalMultiPlayer/commit/8e3fa4877937d780e290a520a163c54dd9da3aae should fix this, The new mod control stuff was was causing problems, I commented on it in the PR: https://github.com/TehGimp/KerbalMultiPlayer/pull/591#issuecomment-32657587

EDIT: Just realised it's not merged yet

[Aringarosa]

Ah great, I'll test it immediately.

[godarklight]

Unfortunately hashashins commit does not fix the problem for me. I really should double check that next time I reach for that close button :(

[Aringarosa]

Ok, Kethane loads again as expected and all the other mods also. For me, it is then done. Can be closed.

Edith says: Ah now I understand the stop at the beginning. That's when KMP first generates the entire SAH.

[godarklight]

Definitely still does not work for me with toolbar.

AddonLoader: Instantiating addon 'ToolbarManager' from assembly 'Toolbar' [Debug] : Files start to be hashed here [Debug] : Added and hashed: (yada yada yada) [Debug] : Files finish hashing here ToolbarButtonWrapper: Loading ToolbarManager. yada yada yada (Loads squad sounds here) IOException: Sharing violation on path /media/raid/games/KSP_linux/GameData/000_Toolbar/folder.tga (More IOExceptions) (Loads squad flags here)

I'll check if we are closing the streams properly.

[Aringarosa]

Hmm

Which version do you use? I have no such fault code with Toolbar 1.4.2.

[godarklight]

It's broken with both Toolbar 1.4.1 and 1.4.2

The above commit should fix things properly, and it also keeps the original hashing where it was. It seems that KSP doesn't take control away from us so closing the streams was enough to stop the bug.

You can see above that the access violation occurred way after mod control finished hashing.

[Aringarosa]

Jup I have only seen this error I could not find anywhere in my logs. Maybe it's because what mods you have. KSP's very liniar terms of loading the mods.

[TehGimp]

My understanding is that the Kethane issue reported here is fixed--please re-open if I have misinterpreted or it is re-encountered.

[godarklight]

I ran into this bug again today, but with a slightly different effect. KSP would refuse to load: http://youtu.be/OkbJkB-kqm4

This is all I really need: darklight@chrislinux:~/.config/unity3d/Squad/Kerbal Space Program$ cat Player.log | grep Exception IOException: Sharing violation on path /media/raid/games/KSP_linux/KSP.log IOException: Sharing violation on path /media/raid/games/KSP_linux/GameData/Squad/Parts/Aero/Ailerons/part.cfg

Dazoe's change to the newer loading type would most likely fix this (#634), but to avoid the hang completely perhaps we can not block where it loads, but block if a user presses the connect button.

[godarklight]

Ctrl+Alt+escape on linux is leaving ghost KSP copies around, which causes problems exactly like this bug used to, but it is not this bug.