search

TehNut-Mods / Harvest

Right click harvesting
MIT License
14 stars 19 forks source link

Migrate fabric mod to 1.16.3 #30

Open Luro02 opened 4 years ago

Luro02 commented 4 years ago

Seems to be working as expected.

I followed this guide: https://fabricmc.net/wiki/tutorial:migratemappings

TehNut commented 4 years ago

Is this actually necessary for it to run on 1.16.3? All you did was change the versions for tooling, none of the code was changed.

Luro02 commented 4 years ago

Yeah, I was surprised as well. I am currently running this mod on a 1.16.3 Server and it is working as expected. (Linux commit isn't necessary, but I thought it would be nice to commit).

I have very little experience with java and modding, so I don't know if I did something wrong.

TehNut commented 4 years ago

Well what I'm asking is that since there was no code change required, wouldn't the existing release already work on 1.16.3?

Luro02 commented 4 years ago

No I don't think that the existing release would work, because you would get an error about the mod requiring an older minecraft version.

Luro02 commented 4 years ago

@TehNut could you merge this PR?

Leeo97one commented 3 years ago

I can confirm that the existing release already work on 1.16.3.

ThexXTURBOXx commented 3 years ago

I can also confirm, but I would also like to get the versions added in CurseForge, so we can use the Twitch Launcher to download/update the mod with that as well :)