TehNut-Mods / MoreChisels

Extra chisels to chisel things with.
Other
6 stars 7 forks source link

Gem Chisels are not translatable #7

Closed Adaptivity closed 9 years ago

Adaptivity commented 9 years ago

There are only "item.morechisels.chisel.gem.name=%s Chisel" line in .lang file but the actual gem names not there.

TehNut commented 9 years ago

That can't really be solvable since I don't provide the names. I'll see if I can setup a system for it, but for now, this is the best you get.

Adaptivity commented 9 years ago

So, consider providing names for them. And why close this? You'll forget about it then.

TehNut commented 9 years ago

How can I provide names for an infinite number of possibilities?

TehNut commented 9 years ago

And on that note, how do you plan to add translations for an infinite number of possibilities?

Adaptivity commented 9 years ago

Infinite number? Are there are infinite number of ruby types? You can't give one string for all ruby from different mods? Maybe I understood something incorrectly but if it really impossible... ok.

TehNut commented 9 years ago

The Gem chisels are created through oreDict entries. There are theoretically an infinite number of gems.

Adaptivity commented 9 years ago

An update on this: Buildcraft Additions automatically detects dusts through oreDict (as I know) but they actually can be translated. You can check the code here: https://github.com/BCA-Team/Buildcraft-Additions/pull/296 and maybe add it into the your mod.

TehNut commented 9 years ago

Completed in e3a59abcb5da6133332f108acd538a90de9b0b76