search

TehNut-Mods / ResourcefulCrops

Simply JSON based resource crops
MIT License
12 stars 7 forks source link

API contains reference to package outside of API #16

Closed InfinityRaider closed 8 years ago

InfinityRaider commented 8 years ago

https://github.com/TehNut/ResourcefulCrops/blob/1.7.10/src/main/java/tehnut/resourceful/crops/api/util/helper/ItemHelper.java#L8

EDIT: also contains reference to external library (which I personally find quite annoying): https://github.com/TehNut/ResourcefulCrops/blob/1.7.10/src/main/java/tehnut/resourceful/crops/api/util/cache/WorldCache.java#L9

TehNut commented 8 years ago

For the first thing:

Oops.

For the second thing:

I forgot to setup the buildscript to de-lombok the API and deobf jars.

TehNut commented 8 years ago

Alright, try with build 20

InfinityRaider commented 8 years ago

Its fine, I removed the call to the debugger and replaced the @SneakyThrows annotations with try{} catch() {} statements, the code isn't compiled or runs during debugging, it just sits there being referenced by my code. I thought I'd report it because others might run into this as well. I'll give it a go though.