TehNut-Mods / ResourcefulCrops

Simply JSON based resource crops
MIT License
12 stars 7 forks source link

crash on startup #27

Closed zedner closed 8 years ago

zedner commented 8 years ago

Edited with pastebin: http://pastebin.com/KAFTaW1t

TehNut commented 8 years ago

Did you modify your seed json at all?

zedner commented 8 years ago

no, just dragged your mod into mods folder and started minecraft.

TehNut commented 8 years ago

Could I get a copy of your seed json?

zedner commented 8 years ago

sure if i knew where to find it :D

TehNut commented 8 years ago

../config/ResourcefulCrops/Seeds.json

zedner commented 8 years ago

its empty...

TehNut commented 8 years ago

Well then, that's a problem...

For now, you can copy all this into it to (hopefully) avoid the crash.

http://tehnut.info/share/CDp8ZuaRHJ.txt

zedner commented 8 years ago

ok it worked, thx

Sailren commented 8 years ago

i have the same exact crash

TehNut commented 8 years ago

Just to be clear, the file is there, it's just empty, correct?

TehNut commented 8 years ago

I'm unable to reproduce this both indev and in a game environment.

zedner commented 8 years ago

ok dude, i dont know what to say, sorry if i wasted your time.

TehNut commented 8 years ago

I meant it more as a "This is weird, why would it happen to others and not me?"

TehNut commented 8 years ago

Alright, so did some more testing. It does not happen alone. Only with other mods. That is why I couldn't reproduce. Hum...

TehNut commented 8 years ago

To explain what happened:

Other mods are doing stupid shit. They query OreDictionary.getOres(entry) without checking OreDictionary.doesOreNameExist(entry) first. The latter checks if the entry exists without adding anything to the dictionary. The former checks if it exists and if not, it will add an entry with an empty list.

By querying OreDictionary.getOres(entry) blindly, it spams the OreDict with values that shouldn't be there.