TehNut-Mods / ResourcefulCrops

Simply JSON based resource crops
MIT License
12 stars 7 forks source link

Farming Station Planting Null Seed #4

Open TehNut opened 9 years ago

TehNut commented 9 years ago

When you have no hoe in the Farming Station and it plants the crop on Farmland, it plants a null crop. I'unno why.

bochen415 commented 9 years ago

Powered ender io farming station with tier 4 seeds without any tools crashed the instance

https://gist.github.com/bochen415/0feeaf1251840d3fc674

joye-ramone commented 7 years ago

For me issue with Ender IO planter still present in latest version for minecraft 1.10. Do you any idea how to fix this?

darkphan commented 7 years ago

This is still a problem. Any automation results in null seeds, if those seeds are broke then the clien and/or server will crash. I really like this mod, as it appears to be the only one that lets you make custom seeds/crops.

bochen415 commented 6 years ago

Using Plant Gatherer from Industrial Foregoing results in null seeds.

Recreated in a minimal environment: ResourcefulCrops-1.12-2.1.1-62 MinecraftForge-1.12.2-14.23.0.2532 industrialforegoing-1.12.2-1.5.4-91 tesla-core-lib-1.12-1.0.11 Forgelin-1.5.1

bochen415 commented 6 years ago

I forgot this https://gist.github.com/bochen415/f30a24258507a0b8791505450a90b373

TehNut commented 6 years ago

...But I specifically tested with Industrial Foregoing and even yelled at Buuz to get this change implemented. https://github.com/Buuz135/Industrial-Foregoing/commit/bae76f2bcf60dd6869092932eb50f7413523231e

CyberLeo commented 6 years ago

CyberLeo/ResourcefulCrops@1.10 works for me. Not wholly sure why. @TehNut are you still accepting pull requests for 1.10?

TehNut commented 6 years ago

No, especially if they pull CoFH crap into the workspace.

CyberLeo commented 6 years ago

No, especially if they pull CoFH crap into the workspace.

I must admit I am disappointed by the immaturity of this comment.

Oh well. It's here if anyone else wants to use it.

TehNut commented 6 years ago

Didn't realize not wanting to pull a coremod that isn't doing anything into my workspace was "immature".

¯\_(ツ)_/¯

CyberLeo commented 6 years ago

Your desire is not immature; just your choice of words.

Regardless, I've had a deeper look into this, and it seems as though EnderIO had at some point switched from embedding CoFHapi to importing CoFHlib as a submodule.

Given your reaction, I can surmise you would feel similarly negatively towards embedding enough of cofh.api.energy to allow symbol resolution to complete. Thus, there seems to be no way to simultaneously provide EnderIO integration from within ResourcefulCrops and satisfy your desire to avoid CoFH.

TehNut commented 6 years ago

This is unofficial mod development for a children's video game about virtual Legos. If you were expecting professionalism from somebody who does this as a hobby, you came to the wrong place.