TehNut-Mods / ResourcefulCrops

Simply JSON based resource crops
MIT License
12 stars 7 forks source link

Agricraft Compatibility #5

Closed TehNut closed 8 years ago

TehNut commented 9 years ago

Need to look into it a bit more (Both the API and actually how Agricraft works).

Agricraft API

TehNut commented 9 years ago

I do plan to have this generate defaults if Agricraft is loaded. So I'll need some mutations for the default crops.

@BBoldt Any ideas?

BBoldt commented 9 years ago

Check what the defaults are for the magical crops integration, those defaults were set by the agricraft creator so I see no reason to go against them too much.

In my pack I added some custom crops of my own, if you want to look at them for inspiration at all: https://github.com/BBoldt/Unabridged/blob/master/scripts/Agricraft.zs Not that many there though.

TehNut commented 9 years ago

Didn't realize MCrops had Agricraft compat. Will look through there, then.

Compat

InfinityRaider commented 9 years ago

Hello I'm the creator of agricraft, I have added Magical Crops compat from my side, I've also looked to add compatibility for your mod from my side, but it appears you're using TileEntities for your crops so I think it'd be better to do it from your side.

You would have to register an ICropPlant (https://github.com/InfinityRaider/AgriCraft/blob/master/src/main/java/com/InfinityRaider/AgriCraft/api/v1/ICropPlant.java ) for every seed via the API: https://github.com/InfinityRaider/AgriCraft/blob/master/src/main/java/com/InfinityRaider/AgriCraft/api/v1/APIv1.java#L95

TehNut commented 9 years ago

Wonderful! Will look into that when I get a chance.

InfinityRaider commented 8 years ago

Implemented from my side: https://github.com/InfinityRaider/AgriCraft/blob/master/src/main/java/com/InfinityRaider/AgriCraft/compatibility/resourcefulcrops/ResourcefulCropsAPI.java https://github.com/InfinityRaider/AgriCraft/blob/master/src/main/java/com/InfinityRaider/AgriCraft/compatibility/resourcefulcrops/CropPlantResourcefulCrops.java

Only have one little request, would it be possible to expose the Overlay IIcons to the API?

TehNut commented 8 years ago

Agricraft's implementation was released, closing.