search

TehNut / Xtones

An "official" clone of Ztones
MIT License
2 stars 13 forks source link

Fix Glaxx blocks and change type counting #3

Closed DeadSix27 closed 7 years ago

DeadSix27 commented 7 years ago

Fixed Glaxx blocks not being see-through. Changed type counting to start from 0.

ChloeDawn commented 7 years ago

Have you tested to make sure BlockRenderLayer.TRANSLUCENT behaves for all other block types? It should work fine but I want to be sure.

DeadSix27 commented 7 years ago

@InsomniaKitten

My MC-Modding knowledge is rather limited.

What does "behaves for all other block types" mean exactly?

As far as I can see only Glaxx is ever BlockRenderLayer.TRANSLUCENT. register(new BlockXtone("glaxx", new ItemStack(Blocks.GLASS)).setSeeThrough());

And that works just fine, with and without OptiFine.

image

TehNut commented 7 years ago

The off by one was intentional as most users don't have a development background and find starting at 0 odd

TehNut commented 7 years ago

If you remove the type count change, I'll pull this, though I still need to fix them causing shadows

DeadSix27 commented 7 years ago

@TehNut reverted it, btw, I tried it myself but failed to add the flat lamps. That's beyond my knowledge of forge and co. Are you going to add them?

TehNut commented 7 years ago

Unsure. Possibly

TehNut commented 7 years ago

Formatting nitpick, could you re-add the space after the +

TehNut commented 7 years ago

I'll cherry-pick to 1.11 when I get home