search

TehShrike / deepmerge

A library for deep (recursive) merging of Javascript objects
MIT License
2.75k stars 216 forks source link

d.ts type definition error #179

Open eczn opened 4 years ago

eczn commented 4 years ago

image

⬆️ the type of t4.a should be a number type, not never.

TehShrike commented 4 years ago

What would be the correct way to fix the type definition? https://github.com/TehShrike/deepmerge/blob/master/index.d.ts#L1-L2

eczn commented 4 years ago

What would be the correct way to fix the type definition? https://github.com/TehShrike/deepmerge/blob/master/index.d.ts#L1-L2

https://github.com/TehShrike/deepmerge/pull/181 here

eczn commented 4 years ago

image

hakimio commented 4 years ago

@TehShrike any plans to merge the PR?

TehShrike commented 3 years ago

Sorry for not looking in for a while – any other TS folks want to give #198 a review? @teppeis @RebeccaStevens @s-edlund

RebeccaStevens commented 3 years ago

I can probably give it a review a bit later today

RebeccaStevens commented 3 years ago

Sorry I took a bit longer to do this than I said I would but I just reviewed it. It's good but I found some issue with it; I've commented them there.