search

TehShrike / deepmerge

A library for deep (recursive) merging of Javascript objects
MIT License
2.75k stars 216 forks source link

#185 change customMerge signature for merging empty values #205

Closed TheHaff closed 3 years ago

TheHaff commented 3 years ago

change customMerge signature to allow for ignoring null or empty string overwrites. ref: https://github.com/TehShrike/deepmerge/pull/185#issuecomment-703910705

i think it would be nice to just have a ignoreEmpty optional flag but i threw in a util function there so this ain't so bad is it?

TheHaff commented 3 years ago

@TehShrike anything i should do differently maybe?

RebeccaStevens commented 3 years ago

@TheHaff me and @TehShrike are working on v5 of this library atm - this will probably be merged into the v5 branch. Do you want to rebase this PR off that branch?

TheHaff commented 3 years ago

@TheHaff me and @TehShrike are working on v5 of this library atm - this will probably be merged into the v5 branch. Do you want to rebase this PR off that branch?

ah ok sweet, my rebase got messy so i just created a new one over here https://github.com/TehShrike/deepmerge/pull/228