search

TehShrike / deepmerge

A library for deep (recursive) merging of Javascript objects
MIT License
2.75k stars 216 forks source link

Un-deprecate clone, make it not a liar about the root object #225

Closed TehShrike closed 3 years ago

TehShrike commented 3 years ago

Fixes #208 Potentially fixes #186 Fixes #163 Potentially fixes #212

TehShrike commented 3 years ago

Going back to #209 I was having trouble parsing it all – is there anything missing from the implementation in this pull request here?

RebeccaStevens commented 3 years ago

I think this is all good to be merged.

I don't think it fully addresses #186 or #212 though, I'll work on them after this (and my typescript work) is merged.

TehShrike commented 3 years ago

Yeah, #186 and #212 both also described other new behaviors, but I'm not sure that any of those other new behaviors are actually a good idea to implement, and I'd want to talk a lot more before moving forward with any of them.

But I am solidly on board with undeprecating clone and making it apply to the target root.

lipnitsk commented 2 years ago

@TehShrike are you planning on releasing v5 anytime soon?

RebeccaStevens commented 2 years ago

@lipnitsk There's no current timeline for v5's release. In the mean time I recommend using deepmerge-ts.