Open RebeccaStevens opened 3 years ago
@RebeccaStevens Hey I think you did a great job, what about creating a separate package with implementation from the current pr? I guess it brings much more value than wait until the maintainer decides to accept your work. I'll be your first user :dd
We want to use your implementation in Osome.com, and I faced the next dilemma to copy-paste and go or use your package and maintain it together. Wait for your thoughts.
I'd be happy to. I've actually been thinking about doing this already but haven't got round to it.
Any suggestions for a name of the package? deepmerge2
is already taken 😛. I might just release it under my user scope @rebeccastevens/deepmerge
.
I've also got some ideas on improving the functionality. I'd probably also end up dropping native support for es5.
@RebeccaStevens I guess the name is doesn't matter in terms of the end user. But the one way to think about it is how to get more SEO traffic :d
So it can be
ts-merge-deep type-deepmerge typed-deepmerge
So anyway, wait for your next steps 💯
@frolovdev I've just release my own take on deep merge.
https://www.npmjs.com/package/deepmerge-ts
Currently the merging functionality can't be customized but that's what I'm going to be working on next. - Done
@RebeccaStevens Hey I think you did a great job, what about creating a separate package with implementation from the current pr? I guess it brings much more value than wait until the maintainer decides to accept your work. I'll be your first user :dd