search

TehShrike / deepmerge

A library for deep (recursive) merging of Javascript objects
MIT License
2.75k stars 216 forks source link

Deno? #236

Closed martin-braun closed 2 years ago

martin-braun commented 3 years ago

Hi,

are there any plans to port deepmerge over to Deno? A consistent solution for both engines would be nice and should be possible without much additional maintaining, since Deno is just node on steroids.

Cheers.

RebeccaStevens commented 3 years ago

We could possibly look into doing this as part of the next major.

@TehShrike I've got plenty of free time to get back into working on the next release. We should probably have another meeting and talk about were we were up to.

RebeccaStevens commented 2 years ago

For now you can use https://deno.land/x/deepmergets

martin-braun commented 2 years ago

@RebeccaStevens Thanks a lot. So this is just temporary or final? Should I close this issue or keep it open? Is Deno support planned on this repo? Is this project even using the smart merge tech that you market on your repo?

Thanks in advance. :)

RebeccaStevens commented 2 years ago

My plans at the moment are to basically make version 5 of library the same as the current deepmerge-ts library. But @TehShrike is the owner of this library and so it's up to him whether or not that will happen. I know he's not fan of abandoning the current API and would like to keep version 5's as close to version 4's as possible. I guess my job is to convince him to make the change.

This library isn't using the smart merging strategy that deepmerge-ts is using. In my benchmarking, this library is actually super slow compared to deepmerge-ts and all of the other competing libraries.

Keep this issue open for now as this library doesn't have Deno support yet.

TehShrike commented 2 years ago

are there any plans to port deepmerge over to Deno? A consistent solution for both engines would be nice and should be possible without much additional maintaining, since Deno is just node on steroids.

I have not used deno. What changes would need to be made?

martin-braun commented 2 years ago

@TehShrike It would really require you to learn about it and use it in the first place. You can import your library via hotlinking and test it. Once it runs, you could publish your module on https://deno.land/x/.

TehShrike commented 2 years ago

That is definitely a thing I could do