search

TehShrike / world-english-bible

The World English Bible translation in JSON
23 stars 6 forks source link

James 1:21-22 missing a space #1

Closed saibotsivad closed 6 years ago

saibotsivad commented 6 years ago

Looking at James 1:21-22 the output JSON doesn't have a space at the end of 21 like it should: https://github.com/TehShrike/world-english-bible/blob/master/json/james.json#L193

The raw HTML of that section looks like:

which is able to save your souls.<a href="#FN2" class="notemark">†<span class="popup"> or, preserve your life.</span></a>  <span class="verse" id="V22">22&#160;</span>But be doers of the word
TehShrike commented 6 years ago

The space is missing in the intermediate JSON form, too, so the space must have been lost during the HTML parsing.

TehShrike commented 6 years ago

Okay, I finally think I got everything tracked down. I pushed up a bunch of commits that fix some general whitespace issues.

Random whitespace elements are now processed, and inside of stanzas, there are now separate "line text" and "line break" objects, instead of just "line" objects. The old data model was insufficient because there are plenty of places where verses in stanzas would span multiple lines, like in Deborah's song.

The changes have been published as 1.0.0.

saibotsivad commented 6 years ago

Thanks! ❤️