search

TehShrike / world-english-bible

The World English Bible translation in JSON
23 stars 6 forks source link

New "type" value of header in psalms not listed & object errors within psalms #4

Open JordanHoffman opened 3 years ago

JordanHoffman commented 3 years ago

I was checking through the psalms. Once you get to ch3, there's a "type" key with the value of "header". This is not listed in your main page under object types.

Issue: The stanza which starts for the 1st psalm does not end until the 2nd psalm ends. I think the intention is for each stanza to start and end when each psalm starts and ends.

Issue: Right after the line-break to end chapter 1 in psalms and right before the line text for ch.2, there's a an object of type "line text" that just has a single space for a value. This line text also has ch number of 2 but verse number of 6 making it out of order. since right after it the proper order starts with ch2 verse 1

Edit: Another Issue: This occurs after the header for the 7th psalm. It's an error. { "type": "line text", "chapterNumber": 7, "verseNumber": 10, "sectionNumber": 1, "value": " " },

ArtskydJ commented 3 years ago

I also ran into the second issue...

Note lines 155 - 161. Chapter 2 starts with verse 6 (Ch 1 has 6 verses)

https://github.com/TehShrike/world-english-bible/blob/4dd194687253f123d211eaf18a9a0c7accdb93ea/json/psalms.json#L145-L168