Tehreer / SheenBidi

A sophisticated implementation of Unicode Bidirectional Algorithm
Apache License 2.0
127 stars 21 forks source link

Inconsistent public header directory structure #28

Closed glebm closed 5 days ago

glebm commented 5 days ago

When installing SheenBidi, the headers go into SheenBidi subdirectory, e.g.:

/usr/local/include/SheenBidi/SBBase.h

To include it, one would write #include <SheenBidi/SheenBidi.h>

However, when using SheenBidi as a subproject (e.g. via CMake), there is no subdirectory, so the correct way to include it is #include <SheenBidi.h>.

It'd be great if there were no such discrepancy. One way to do that would be to move all the headers to Headers/SheenBidi subdirectory here, so that it's always #include <SheenBidi/SheenBidi.h>

glebm commented 5 days ago

Oh nevermind, I misunderstood. The correct way to include it is #include <SheenBidi.h> and I simply need to add /usr/local/include/SheenBidi to the include path