Teichlab / bbknn

Batch balanced KNN
MIT License
149 stars 25 forks source link

Update access of obsm keys #13

Closed ivirshup closed 5 years ago

ivirshup commented 5 years ago

Obsm is going to be a Mapping soon, instead of a structured array. This PR should prevent that change from breaking bbknn.

ktpolanski commented 5 years ago

Cool, thanks for this. When's this going live scanpy-side?

ivirshup commented 5 years ago

The anndata release where obsm and varm will be Mappings is the one after v0.6.21, probably v0.7.0. Those objects have had a .keys() method for a while though (at least over a year), so this won't break current installs.

ktpolanski commented 5 years ago

Pushed into pip as 1.3.4