Teichlab / bbknn

Batch balanced KNN
MIT License
150 stars 25 forks source link

make connectivity compatible with umap learn 0.4 #22

Closed iandriver closed 4 years ago

iandriver commented 4 years ago

fuzzy_simplicial_set in umap 0.4 is now: return result, sigmas, rhos

This adds the check for if connectivities is a tuple, get the result (connectivities[0]) instead, thus connectivities.tocsr() won't throw an error. Backward compatible so shouldn't do anything other than allow use of umap 0.4. Code from scanpy

ktpolanski commented 4 years ago

Thanks for bringing this to my attention and writing the fix in such a nice, backwards compatible way. Released as 1.3.8.