search

Teichlab / bbknn

Batch balanced KNN
MIT License
149 stars 25 forks source link

`n_trees` is now `annoy_n_trees` #41

Closed ghost closed 3 years ago

ghost commented 3 years ago

Thanks for the great method!

The change of n_trees to annoy_n_trees seems to have broken compatibility with scanpy's bbknn module (sc.pp.external.bbknn). Are there any plans to make changes to that module as well?

ktpolanski commented 3 years ago

Thanks for the heads up, I'll pull request in the up to date argument names. For now feel free to use bbknn.bbknn(), which sc.external.pp.bbknn() is just a wrapper for anyway.

ghost commented 3 years ago

Thank you!

ktpolanski commented 3 years ago

I opened a pull request on the day, haven't heard back yet.