search

Teichlab / cellphonedb

MIT License
340 stars 105 forks source link

pval[pval==0] = 0.0009 (plot_dot_by_column_name.R) #206

Closed peerkarmaus closed 3 years ago

peerkarmaus commented 3 years ago

In the plotting function _plot_dot_by_columnname.R, Line 34 reads pval[pval==0] = 0.0009

Is there a floating point issue in the python code or why are zeros converted to what seems like an arbitrary "0.0009" value? Many of my results are pval==0, so I am worried this could be an issue introduced by limited floating points.

Can someone comment on this?

mief commented 3 years ago

Yes, the zeros are converted to a small arbitrary value.