Teifun2 / nextcloud-cookbook-flutter

Flutter Project for the nextcloud plugin "cookbook"
Creative Commons Zero v1.0 Universal
103 stars 25 forks source link

Material 3 design user avatar and ingredient groups #201

Closed arroyoj closed 1 year ago

arroyoj commented 1 year ago

@Leptopoda, thanks for the new material 3 design. While testing out the new app, I noticed that the user avatar is no longer a perfect circle but is now an oval: user_avatar_oval It looks like there is a missing Center() around the UserImage(). I'm happy to submit a PR to fix that, but I wasn't sure if you were done working on that part.

Also, I noticed a change in how ingredient groups are displayed in the new design. Now the group names are centered instead of left aligned. Was that intentional? If not, I can submit a PR to restore the previous layout. For reference, here are screenshots from v0.7.9 vs the new design. v0.7.9: ingredient_group_0 7 9 current version: ingredient_group_develop

Leptopoda commented 1 year ago

I noticed that the user avatar is no longer a perfect circle but is now an oval:

Yeah I also noticed this and forgot to fix it.

Now the group names are centered instead of left aligned. Was that intentional?

I think aligned to the start should be better.

PRs as always welcome :)

EDIT: I just assigned you for now