Tejas1510 / Athavani

😻 Athavani/Memories is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years.
https://athavani.vercel.app
MIT License
37 stars 113 forks source link

SignIn with google not working #313

Closed ayushkwal closed 3 years ago

ayushkwal commented 3 years ago

Describe the bug On signin, an easy click for signin with google is not created.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Website Login Page'
  2. See G+ button not working

Expected behavior on clicking that button, it should logged in.

Additional context Please give me a chance to make this button using Passport

welcome[bot] commented 3 years ago

Hello there!πŸ‘‹ Welcome to the project!πŸš€βš‘ Thank you and congratsπŸŽ‰ for opening your very first issue in this project. Athavani is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years. Please adhere to our Code of Conduct. Please make sure not to start working on the issue, unless you get assigned to it.πŸ˜„

ChitvanRamani22 commented 3 years ago

@ayushkwal go ahead!!

rushikadivar commented 3 years ago

I would like to work on this issue to get into to login page button. Please assign me

ChitvanRamani22 commented 3 years ago

@rushikadivar the issue is already assigned lets wait for sometime for @ayushkwal to respond . Till then feel free to take up other issues which are not assigned. Thanks.

rushikadivar commented 3 years ago

Okay, looking for other issues! and I want to share my idea that the signing system should expect like when user get to log in (sign in) firstly it will check to our database that it is there or the user can directly signing using google auth by clicking the G+ button. is this a right way?

ChitvanRamani22 commented 3 years ago

@ayushkwal any updates?

ayushkwal commented 3 years ago

Yes, will pull till tomorrow.

On Mon, Jun 21, 2021 at 12:20 PM ChitvanRamani22 @.***> wrote:

@ayushkwal https://github.com/ayushkwal any updates?

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tejas1510/Athavani/issues/313#issuecomment-864775681, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQWQAVCGA7WEJFRIMGAPYMDTT3ONDANCNFSM46ZFNYPQ .

ChitvanRamani22 commented 3 years ago

@ayushkwal any further updates??

ayushkwal commented 3 years ago

Someone already implemented it through firebase.

On Thu, 24 Jun, 2021, 12:10 PM ChitvanRamani22, @.***> wrote:

@ayushkwal https://github.com/ayushkwal any further updates??

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tejas1510/Athavani/issues/313#issuecomment-867382447, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQWQAVAFFWR5K7LB7EO2I73TULHPXANCNFSM46ZFNYPQ .