search

Tejas1510 / Athavani

😻 Athavani/Memories is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years.
https://athavani.vercel.app
MIT License
37 stars 113 forks source link

Creating 404 page for website. #314

Closed ritik-vashist closed 3 years ago

ritik-vashist commented 3 years ago

Currently website is not having 404 page. So i would like to add this page to it by shifting app.js to different components. And bind the routes accordingly.

ritik-vashist commented 3 years ago

@AmeyaJain-25 sir i request you to assign this task to me.

ritik-vashist commented 3 years ago

It would be better if your give any design layout selected by the project team for this page.

ChitvanRamani22 commented 3 years ago

@ritik-vashist go ahead!! Will send you a template.

ChitvanRamani22 commented 3 years ago

20210616_165948.jpg 20210616_165935.jpg @ritik-vashist you can go with any one of them. But try to follow the color theme.

ChitvanRamani22 commented 3 years ago

@ritik-vashist which tempelate have you choosen?

ritik-vashist commented 3 years ago

I have choosen second template, due to some family issue and end sem exams work is delayed by a week I hope I will complete it by this week. Sorry for the inconvenience caused by my side.

ritik-vashist commented 3 years ago

@ChitvanRamani22 ma'am you could assign this task to someone else as i am stuck in some family matter. Sorry for the inconvenience caused by my side.

Navdeepsingh4298 commented 3 years ago

I would like to do this. i've read the conversation. second template need to be made. i can do it.

Navdeepsingh4298 commented 3 years ago

i have seen somebody already added error404 page 5 months ago, but that doesn't seem working.

ChitvanRamani22 commented 3 years ago

i have seen somebody already added error404 page 5 months ago, but that doesn't seem working.

Yes go ahead

AmeyaJain-25 commented 3 years ago

i have seen somebody already added error404 page 5 months ago, but that doesn't seem working.

Actually the error 404 works properly, but if you see the app.js code, the Switch from react-router-dom is used somewhere at center and the sidebar and navbar is outside of it. Hence, if you go to any random url after base path, it shows the sidebar and navbar with middle part empty