search

Tejas1510 / Athavani

😻 Athavani/Memories is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years.
https://athavani.vercel.app
MIT License
37 stars 113 forks source link

Improved the UI of Create memory form #317

Closed ambalika24 closed 3 years ago

ambalika24 commented 3 years ago

@AmeyaJain-25 Sir, i have improved the UI of create memory form, kindly check the PR.

welcome[bot] commented 3 years ago

Hello there!👋 Welcome to the project!💖 Thank you and congrats🎉 for opening your first pull request. Athavani is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years. Please make sure you have followed our contributing guidlines .🙌🙌 We will get back to you as soon as we can 😄.

ChitvanRamani22 commented 3 years ago

@ambalika24 can you please add the ss of the earlier one and the one which u have designed. Would be really helpful. Thanks

ambalika24 commented 3 years ago

Sure. or

ChitvanRamani22 commented 3 years ago

@ambalika24 how did it earlier look like? And also try to make a habit of attaching an issue which is referring this pr.

ambalika24 commented 3 years ago

Sir earlier the form looked like this- or and after my final design is- newform

AmeyaJain-25 commented 3 years ago

@ambalika24 ATM the earlier background-color suits more on our theme. And secondly i am a girl😅 @AmeyaJain-25 WDYT?

I think it's fine. Because the sidebar ia also coming in light black. I think we can keep it white. Once the background is done and sidebar is done, we can change the color.

Other than color, the UI is awesome. Also the shadow effects, etc are good. Nice work @ambalika24

I'm done with the review @ChitvanRamani22 . Once you approve this, just merge it.

ChitvanRamani22 commented 3 years ago

@ambalika24 great work!! Thanks for your efforts. Keep contributing.

welcome[bot] commented 3 years ago

Hello there!👋 Congrats🎉 on getting your first pull request merged! All the best for your amazing open source journey ahead 🚀.

ambalika24 commented 3 years ago

@ambalika24 ATM the earlier background-color suits more on our theme. And secondly i am a girl😅 @AmeyaJain-25 WDYT?

@ambalika24 ATM the earlier background-color suits more on our theme. And secondly i am a girl😅 @AmeyaJain-25 WDYT?

Okay, sorry ma'am 😅

ambalika24 commented 3 years ago

@ambalika24 ATM the earlier background-color suits more on our theme. And secondly i am a girl😅 @AmeyaJain-25 WDYT?

I think it's fine. Because the sidebar ia also coming in light black. I think we can keep it white. Once the background is done and sidebar is done, we can change the color.

Other than color, the UI is awesome. Also the shadow effects, etc are good. Nice work @ambalika24

I'm done with the review @ChitvanRamani22 . Once you approve this, just merge it.

Thank you Sir!!