search

Tejas1510 / Athavani

😻 Athavani/Memories is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years.
https://athavani.vercel.app
MIT License
37 stars 113 forks source link

Crappy Design #327

Closed ayushkwal closed 3 years ago

ayushkwal commented 3 years ago

I have changed design of footer and removed toast and presenting toast data inside form itself.

welcome[bot] commented 3 years ago

Hello there!👋 Welcome to the project!💖 Thank you and congrats🎉 for opening your first pull request. Athavani is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years. Please make sure you have followed our contributing guidlines .🙌🙌 We will get back to you as soon as we can 😄.

ChitvanRamani22 commented 3 years ago

@ayushkwal I appreciate your efforts. But can you please have a look at this. 20210618_102650.jpg

ayushkwal commented 3 years ago

Hmmm... That's strange! I will fix that and will pull again.

ChitvanRamani22 commented 3 years ago

@ayushkwal dont create a new pr just commit the changes in this pr itself.

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @Tejas1510 on Vercel.

@Tejas1510 first needs to authorize it.

ayushkwal commented 3 years ago

Hi Again, Now, it's working fine and looking good. It may be possible that something won't work due to continuous contributions by other users. I will resolve that in next time.

ChitvanRamani22 commented 3 years ago

Hi Again, Now, it's working fine and looking good. It may be possible that something won't work due to continuous contributions by other users. I will resolve that in next time.

But you need to resolve merge conflicts and also look at the checks. Without this merging is not possible.

ayushkwal commented 3 years ago

Well from my side, everything's working fine. You can check it too.

On Fri, 18 Jun, 2021, 7:02 PM ChitvanRamani22, @.***> wrote:

Hi Again, Now, it's working fine and looking good. It may be possible that something won't work due to continuous contributions by other users. I will resolve that in next time.

But you need to resolve merge conflicts and also look at the checks. Without this merging is not possible.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tejas1510/Athavani/pull/327#issuecomment-864041958, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQWQAVHWN5V4ERK7LBL7M73TTNDFLANCNFSM464XEOEQ .

ayushkwal commented 3 years ago

I have resolved the conflicts. Hope, it will work!

ayushkwal commented 3 years ago

Hi, Have you merged it?

ChitvanRamani22 commented 3 years ago

@ayushkwal u would have recieved a mail if it would hve been merged . @Tejas1510 sir will first look at the checks.

welcome[bot] commented 3 years ago

Hello there!👋 Congrats🎉 on getting your first pull request merged! All the best for your amazing open source journey ahead 🚀.

ayushkwal commented 3 years ago

Thankyou very much🥳🥳

On Sat, 19 Jun, 2021, 2:31 PM welcome[bot], @.***> wrote:

Hello there!👋 Congrats🎉 on getting your first pull request merged! All the best for your amazing open source journey ahead 🚀.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tejas1510/Athavani/pull/327#issuecomment-864378938, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQWQAVAUFJVZ5QCHWY2QG6DTTRMGJANCNFSM464XEOEQ .