create separate sidebar component and add some styles

Tejas1510 / Athavani

😻 Athavani/Memories is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years.

https://athavani.vercel.app

MIT License

37 stars 113 forks source link

create separate sidebar component and add some styles #337

Closed Navdeepsingh4298 closed 3 years ago

Navdeepsingh4298 commented 3 years ago

fixes issue #305

First one Before changes and Second one After changes:->

When clickes on any option in sidebar it persist that style.

When i clicked on create memory option it shows like below:

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @Tejas1510 on Vercel.

@Tejas1510 first needs to authorize it.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

athavani – ./server

🔍 Inspect: https://vercel.com/tejas1510/athavani/6hqQ1uBVjgZYU99L3Z7uSCtaBZNa
✅ Preview: https://athavani-git-fork-navdeepsingh4298-issue305-tejas1510.vercel.app

ChitvanRamani22 commented 3 years ago

@Navdeepsingh4298 i could observe that the 404 page is not responsive.

Navdeepsingh4298 commented 3 years ago

i'll fix responsiveness. is sidebar fine now?

Navdeepsingh4298 commented 3 years ago

i've done fix responsiveness issue now it looks like below:

there is one problem i can't be able to change size of loader dynamically according to media query.

Navdeepsingh4298 commented 3 years ago

this is how it looks like in different sizes But i'm unable change size of loader can you help me with this?

Navdeepsingh4298 commented 3 years ago

@ChitvanRamani22 i'm sorry to tag you but i want to fix this issue as soon as possible. because i'm going to have my exams very soon. So, tell me what to do? have a look and also tell me what to do with loader situation. as i can't be able to change its size dynamically.

AmeyaJain-25 commented 3 years ago

Really awesome work @Navdeepsingh4298 It maintained the theme too.

I think everything is good. @ChitvanRamani22 , just have a look to it and merge if everything is good.

ChitvanRamani22 commented 3 years ago

@Navdeepsingh4298 thanks for your efforts. Keep contributing🥳